Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Commit

Permalink
Merge branch 'release-v1.4.3' into release
Browse files Browse the repository at this point in the history
  • Loading branch information
@rhelmer
rhelmer committed Feb 4, 2022
2 parents 0b84a9d + 75b2404 commit 11ebb93
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 7 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Unreleased changes

[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.4.2...master)
[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.4.3...master)

# v1.4.3 (2022-02-03)

[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.4.2...v1.4.3)

* [#788](https://github.com/mozilla-rally/rally-core-addon/pull/788): Ensure that data collection is always enabled in core add-on
when user is enrolled

# v1.4.2 (2022-01-26)

Expand Down
8 changes: 6 additions & 2 deletions core-addon/Core.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,12 @@ export default class Core {

// Initialize the collection engine once we know if
// user is enrolled or not.
this._storage.getRallyID().finally(id =>
this._dataCollection.initialize(id !== undefined));
this._storage.getRallyID().then(id => {
this._dataCollection.initialize(id !== undefined)
}).catch(err => {
console.error("No Rally ID, initializing data collection in unenrolled state", err);
this._dataCollection.initialize(false);
});

// Asynchronously get the available studies. We don't need to wait
// for this to finish, the UI can handle the wait.
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"author": "Mozilla",
"manifest_version": 2,
"name": "Mozilla Rally",
"version": "1.4.2",
"version": "1.4.3",
"homepage_url": "https://github.com/mozilla-rally/rally-core-addon",
"icons": {
"48": "public/img/rally-favicon.svg",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rally_core",
"version": "1.4.2",
"version": "1.4.3",
"type": "module",
"scripts": {
"prebuild": "node scripts/setupTaskcluster.js",
Expand Down

1 comment on commit 11ebb93

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

["assume:repo:github.com/mozilla-rally/rally-core-addon:tag:v1.4.3","queue:route:checks","queue:scheduler-id:taskcluster-github"]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

assume:repo:github.com/mozilla-rally/rally-core-addon:branch:v1.4.3

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/mozilla-rally/rally-core-addon:branch:v1.4.3",
    "queue:route:checks",
    "queue:route:index.xpi.v2.rally-core-addon.revision.11ebb93abbef6501fb5c5dd4a6a42b8d8ef9ec95.taskgraph.decision",
    "queue:create-task:project:none",
    "queue:scheduler-id:xpi-level-1",
    {
      "AnyOf": [
        "queue:create-task:highest:xpi-1/decision",
        "queue:create-task:very-high:xpi-1/decision",
        "queue:create-task:high:xpi-1/decision",
        "queue:create-task:medium:xpi-1/decision",
        "queue:create-task:low:xpi-1/decision",
        "queue:create-task:very-low:xpi-1/decision",
        "queue:create-task:lowest:xpi-1/decision"
      ]
    }
  ]
}
  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2022-02-04T01:29:33.266Z

Please sign in to comment.