This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Add some commands to run Coverage and Checks locally #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncloudioj
reviewed
Apr 12, 2023
ncloudioj
reviewed
Apr 12, 2023
ncloudioj
reviewed
Apr 12, 2023
ncloudioj
reviewed
Apr 12, 2023
ncloudioj
reviewed
Apr 12, 2023
ncloudioj
reviewed
Apr 12, 2023
I'll note there's also the cargo-llvm-cov crate now which appears to be a maybe more convenient alternative to grcov. It's been suggested it works better/is more accurate but I'm wondering if that's due to it forcing |
This Makefile will add some commands to run these coverage and checks locally.
mtbottle
force-pushed
the
DISCO-2318_add_code_coverage_report
branch
from
April 14, 2023 19:38
0e237c3
to
408947a
Compare
This is simpler to use and also cleaner.
mtbottle
force-pushed
the
DISCO-2318_add_code_coverage_report
branch
from
April 14, 2023 20:02
c36a2ed
to
68a1d98
Compare
I've switched to using |
ncloudioj
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does 2 things
This is a first step to getting us higher test coverage to prepare Contile for Rapid Release.