Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Add some commands to run Coverage and Checks locally #530

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

mtbottle
Copy link
Contributor

This change does 2 things

  1. Adding a Makefile to run checks and create a coverage report
  2. Add some tests to a random file (cache)

This is a first step to getting us higher test coverage to prepare Contile for Rapid Release.

@mtbottle mtbottle requested a review from a team as a code owner April 11, 2023 00:34
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
src/server/cache.rs Outdated Show resolved Hide resolved
@pjenvey
Copy link
Member

pjenvey commented Apr 13, 2023

I'll note there's also the cargo-llvm-cov crate now which appears to be a maybe more convenient alternative to grcov. It's been suggested it works better/is more accurate but I'm wondering if that's due to it forcing RUST_TEST_THREADS=1 to avoid a known issue w/ -Cinstrument-coverage If we're seeing intermittent differences in coverage w/ grcov also we'll probably need to force it as well.

@mtbottle mtbottle force-pushed the DISCO-2318_add_code_coverage_report branch from 0e237c3 to 408947a Compare April 14, 2023 19:38
This is simpler to use and also cleaner.
@mtbottle mtbottle force-pushed the DISCO-2318_add_code_coverage_report branch from c36a2ed to 68a1d98 Compare April 14, 2023 20:02
@mtbottle
Copy link
Contributor Author

I've switched to using cargo-llvm-cov because I think it's simpler and cleaner to use.

Copy link
Collaborator

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mtbottle mtbottle merged commit acd2c25 into main Apr 17, 2023
@mtbottle mtbottle deleted the DISCO-2318_add_code_coverage_report branch April 17, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants