Replace custom_2_error by backoff (Firefox 67) (#101)

mozilla-services · Sep 30, 2019 · d5f527f · d5f527f
1 parent 7f51be4
commit d5f527f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/checks/normandy/uptake_error_rate.py b/checks/normandy/uptake_error_rate.py
@@ -51,7 +51,10 @@ async def run(
     by_collection: Dict[str, Dict[str, int]] = defaultdict(dict)
     for row in rows:
         rid = int(row["source"].split("/")[-1])
-        by_collection[rid][row["status"]] = row["total"]
+        # In Firefox 67, `custom_2_error` was used instead of `backoff`.
+        status = row["status"].replace("custom_2_error", "backoff")
+        by_collection[rid].setdefault(status, 0)
+        by_collection[rid][status] += row["total"]
 
     error_rates = {}
     for rid, all_statuses in by_collection.items():

diff --git a/tests/checks/normandy/test_normandy_uptake_error_rate.py b/tests/checks/normandy/test_normandy_uptake_error_rate.py
@@ -21,7 +21,14 @@
     {
         "status": "backoff",
         "source": "normandy/recipe/123",
-        "total": 5000,
+        "total": 4000,
+        "min_timestamp": "2019-09-16T01:36:12.348",
+        "max_timestamp": "2019-09-16T07:24:58.741",
+    },
+    {
+        "status": "custom_2_error",
+        "source": "normandy/recipe/123",
+        "total": 1000,
         "min_timestamp": "2019-09-16T01:36:12.348",
         "max_timestamp": "2019-09-16T07:24:58.741",
     },