Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing telescope push timestamp check #1523

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Fixing telescope push timestamp check #1523

merged 3 commits into from
Dec 20, 2024

Conversation

alexcottner
Copy link
Contributor

We updated the kinto client library and started using the changeset endpoint.
However that endpoint returns records sorted by bucket and collection name, causing this check to be a false positive.
Sorting the records by last_modified first makes this check work and prevents us from hitting this banana peel in the future.

@alexcottner alexcottner requested a review from a team as a code owner December 19, 2024 21:32
@alexcottner alexcottner added the bug Something isn't working label Dec 19, 2024
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This regression was introduced in #1515

The fix would work, but I'd like to contrast it with other solutions:

I approve the PR anyway in case we want the check to be green before our holidays :)

@alexcottner
Copy link
Contributor Author

alexcottner commented Dec 20, 2024

I vote we make this green before the holidays and then follow up.

If we modify how changeset sorts things, there might be a few other impacts to think about. Like the remote-settings-devtools users. But that would be a clean solution if we make everything use changeset and it sorts things in an expected way.

@alexcottner alexcottner merged commit 55f2558 into main Dec 20, 2024
4 checks passed
@alexcottner alexcottner deleted the fix-sync-check branch December 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants