Skip to content

Conversation

@wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Oct 6, 2025

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR adds flathub link to VPN download page. Figma design

Significant changes and points to review

Flathub link in primary and secondary cards.

Issue / Bugzilla link

#16552

Testing

http://localhost:8000/en-US/products/vpn/download/ (using Linux to test primary card and non-linux system to test secondary card)

┆Issue is synchronized with this Jira Task
┆Priority: P2
┆Sprint: Backlog

@wen-2018 wen-2018 marked this pull request as ready for review October 7, 2025 15:37
@wen-2018 wen-2018 requested a review from a team as a code owner October 7, 2025 15:37
@wen-2018 wen-2018 added Needs Review Awaiting code review Frontend HTML, CSS, JS... client side stuff labels Oct 7, 2025
@wen-2018 wen-2018 marked this pull request as draft October 8, 2025 03:38
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc
Minor blocker on missing SVG viewbox

Local integration tests all passed ✅

@wen-2018 wen-2018 force-pushed the add-flathub-link branch 3 times, most recently from 9bb8b66 to ce46895 Compare October 22, 2025 15:25
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.68%. Comparing base (20449c1) to head (d5814aa).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16782      +/-   ##
==========================================
- Coverage   79.68%   79.68%   -0.01%     
==========================================
  Files         159      159              
  Lines        8522     8525       +3     
==========================================
+ Hits         6791     6793       +2     
- Misses       1731     1732       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 💯

@maureenlholland maureenlholland merged commit 20274c0 into mozilla:main Oct 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend HTML, CSS, JS... client side stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants