-
Notifications
You must be signed in to change notification settings - Fork 946
Add Flathub link to VPN download page #16782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc4ce57 to
9960fb1
Compare
9960fb1 to
95ef356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
Minor blocker on missing SVG viewbox
Local integration tests all passed ✅
9bb8b66 to
ce46895
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16782 +/- ##
==========================================
- Coverage 79.68% 79.68% -0.01%
==========================================
Files 159 159
Lines 8522 8525 +3
==========================================
+ Hits 6791 6793 +2
- Misses 1731 1732 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ce46895 to
d5814aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ 💯
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
This PR adds flathub link to VPN download page. Figma design
Significant changes and points to review
Flathub link in primary and secondary cards.
Issue / Bugzilla link
#16552
Testing
http://localhost:8000/en-US/products/vpn/download/ (using Linux to test primary card and non-linux system to test secondary card)
┆Issue is synchronized with this Jira Task
┆Priority: P2
┆Sprint: Backlog