Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3272: API to call FxA apply coupon #4636

Merged
merged 17 commits into from
Jun 12, 2024
Merged

MNTOR-3272: API to call FxA apply coupon #4636

merged 17 commits into from
Jun 12, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Jun 5, 2024 •
edited
Loading

References:

Jira: MNTOR-3272

Description

  • service-side function to apply coupon code for the cancellation flow
  • a new ENV VAR to set the coupon code ID

How to test

In Heroku, subscribe to monthly, make sure the user is subscribed.
Go to settings page and hit cancel

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Preview URL 🚀 : https://blurts-server-pr-4636-mgjlpikfea-uk.a.run.app

Base automatically changed from MNTOR-3271 to main June 6, 2024 16:15
@mansaj mansaj changed the title MNTOR-3272 MNTOR-3272: API to call FxA apply coupon Jun 12, 2024
@mansaj mansaj requested a review from rhelmer June 12, 2024 16:58
@mansaj mansaj marked this pull request as ready for review June 12, 2024 16:59
@mansaj mansaj requested a review from codemist June 12, 2024 16:59
rhelmer
rhelmer approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, just a few comment-related nits

src/utils/fxa.js Outdated Show resolved Hide resolved
src/app/functions/server/applyCoupon.ts Outdated Show resolved Hide resolved
src/app/functions/server/applyCoupon.ts Outdated Show resolved Hide resolved
@mansaj mansaj merged commit 244ac7c into main Jun 12, 2024
15 checks passed
@mansaj mansaj deleted the MNTOR-3272 branch June 12, 2024 20:49
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-4636' destroyed, cloud run service 'blurts-server-pr-4636' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhelmer rhelmer rhelmer approved these changes

@codemist codemist Awaiting requested review from codemist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansaj @rhelmer