-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mntor-3355: integration with e2e, support for email hash based mock-data retrieval #4763
Conversation
…alling back to mock
…st data deletion page.
Preview URL 🚀 : https://blurts-server-pr-4763-mgjlpikfea-uk.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stack trace is from minified source but I suspect the error you're seeing here is from:
blurts-server/src/utils/hibp.js
Line 68 in 2c2c009
throw new InternalServerError(getMessage('error-hibp-connect')) |
The problem is probably that the test server isn't running on the IP address and/or port that is configured. The reason the error message is so confusing here is that:
- it uses the old deprecated
InternalServerError
object, which in the pre-NextJS app (ExpressJS) translated these into HTTP errors automatically - it is attempted to localize the error message, which as a practice I think doesn't make much sense to do because the user should generally never see this
- (2) is calling the deprecated
getMessage
l10n function but it's failing for some reason
I'll make sure we have a ticket in the tech debt backlog to fix (1), for the purposes of this bug I'd suggest changing InternalServerError(getMessage(...)
in src/utils/hibp.js
to just return InternalServerError(...)
and see if that gives you better error messages.
We should also move away from InternalServerError
altogether but I see it is used a ton in the oldest pre-TS/Next code (src/db
and src/utis
) which is why I'm filing that in the backlog, feels like a bigger task to refactor all of that.
Cleanup completed - database 'blurts-server-pr-4763' destroyed, cloud run service 'blurts-server-pr-4763' destroyed |
References:
Jira: MNTOR-3355, MNTOR-3140, MNTOR-3141
Figma:
Description
Mock Endpoints finalized, with emails as environment variables based data retrieval.
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)