Conversation
|
Preview URL 🚀 : https://blurts-server-pr-4796-mgjlpikfea-uk.a.run.app |
Vinnl
approved these changes
Jul 15, 2024
Collaborator
Vinnl
left a comment
There was a problem hiding this comment.
I believe on Relay we use coveralls.io, maybe we want to use that here too, to save the effort of setting up a full pipeline?
| coverageReporters: [ | ||
| // "json", | ||
| "text", | ||
| // "lcov", |
Collaborator
There was a problem hiding this comment.
I think this is the one that generates the HTML report that I use to check if there's any code I forgot to write tests for:
Suggested change
| // "lcov", | |
| "lcov", |
|
@pdehaan are you still working on this one? |
Collaborator
|
I'm assuming no, so closing for now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-
Figma:
Description
Early work on adding JUnit XML reports for the Jest unit tests. Eventually we'll want to ingest these into a pipeline to track tests and test performance over time (which means working on getting these stored as artifacts in the GitHub Actions pipeline too).
Screenshot (if applicable)
Not applicable.
How to test
Run tests locally, look for a root /jest-junit.xml file.
Checklist (Definition of Done)