QA tool for custom data #4857
Merged
QA tool for custom data #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-4857-mgjlpikfea-uk.a.run.app |
9 tasks
rhelmer
requested changes
Jul 25, 2024
codemist
reviewed
Jul 25, 2024
codemist
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Amazing work! Verified locally that the feature works. The FE could use some extra attention, but since this is an admin tool I don't see it as a blocker since it's not user facing. Opened a ticket to enhance it later down the line here.
codemist
reviewed
Jul 30, 2024
Comment on lines
+314
to
+326
| const qaToggles = await getQaToggleRow(sha1); | ||
| let showCustomBreaches = true; | ||
| let showRealBreaches = true; | ||
| if (qaToggles) { | ||
| showCustomBreaches = qaToggles.show_custom_breaches; | ||
| showRealBreaches = qaToggles.show_real_breaches; | ||
| } | ||
|
|
||
| const qaBreaches = !showCustomBreaches | ||
| ? [] | ||
| : await getAllQaCustomBreaches(sha1Prefix); | ||
| if (!showRealBreaches) return qaBreaches as HibpLikeDbBreach[]; | ||
|
|
There was a problem hiding this comment.
Could you leave a comment about what this is doing?
There was a problem hiding this comment.
These lines of code check whether a QA toggles row exists for the current user, and if it does, either show the QA breaches or not.
codemist
reviewed
Jul 30, 2024
| @@ -37,6 +39,17 @@ export async function POST( | |||
| ); | |||
| } | |||
|
|
|||
| // This marks a QA broker as resolved. Collisions aren't a worry because a real user is never admin. | |||
rhelmer
approved these changes
Jul 31, 2024
|
Cleanup completed - database 'blurts-server-pr-4857' destroyed, cloud run service 'blurts-server-pr-4857' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3357, MNTOR-3424, MNTOR-3425
Figma:
Description
Separated from mock endpoints, and added complete customization. Admin is able to turn on/off custom and real data, and is able to adjust each field of the custom breach and broker objects.
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)