Add QA Custom broker data to broker scan results #5359
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemist
commented
Dec 3, 2024
Comment on lines
+414
to
+424
| const qaToggles = await getQaToggleRow(onerepProfileId); | ||
| let showCustomBrokers = false; | ||
| let showRealBrokers = true; | ||
|
|
||
| let scanResults = await knex("onerep_scan_results as sr") | ||
| .select( | ||
| "sr.*", | ||
| "s.*", | ||
| "sr.status as scan_result_status", // rename to avoid collision | ||
| "db.status as broker_status", // rename to avoid collision | ||
| ) | ||
| .innerJoin("onerep_scans as s", "sr.onerep_scan_id", "s.onerep_scan_id") | ||
| .where("s.onerep_profile_id", onerepProfileId) | ||
| .andWhere("sr.manually_resolved", "false") | ||
| .andWhereNot("sr.status", "removed") | ||
| .join("onerep_data_brokers as db", "sr.data_broker", "db.data_broker") | ||
| .orderBy("sr.onerep_scan_result_id"); | ||
|
|
||
| scanResults = scanResults.filter( | ||
| (result) => | ||
| result.broker_status === "removal_under_maintenance" || | ||
| new Date().getTime() - new Date(result.updated_at).getTime() > | ||
| CONST_DAY_MILLISECONDS * 200, | ||
| ); | ||
| if (qaToggles) { | ||
| showCustomBrokers = qaToggles.show_custom_brokers; | ||
| showRealBrokers = qaToggles.show_real_brokers; | ||
| } | ||
| const scan = await getLatestOnerepScan(onerepProfileId); | ||
|
|
||
| let results: OnerepScanResultRow[] = []; |
There was a problem hiding this comment.
The logic here for adding the QA custom broker results is similar to that of getLatestOnerepScanResults() in the same file.
|
Preview URL 🚀 : https://blurts-server-pr-5359-mgjlpikfea-uk.a.run.app |
codemist
commented
Dec 3, 2024
Comment on lines
+451
to
+461
| if (showCustomBrokers) { | ||
| const qaBrokers = await getQaCustomBrokers( | ||
| onerepProfileId, | ||
| scan?.onerep_scan_id, | ||
| ); | ||
| const filteredCustomBrokers = qaBrokers.filter( | ||
| (broker) => broker.manually_resolved === false, | ||
| ); | ||
|
|
||
| results = [...results, ...filteredCustomBrokers]; | ||
| } |
There was a problem hiding this comment.
For QA to test this feature, they should check that the manually_resolved attribute of a custom data broker is getting set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-
Figma:
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)