Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3844: backend logic to update manual resolution bool for scan result #5361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Dec 3, 2024

References:

Jira: MNTOR-3844

Description

  • Modify the underlying db function to take in a boolean for manual resolution field
  • Create a PUT that can modify the manual_resolution field of an existing scan result row

How to test

call the API via PUT

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mansaj mansaj requested review from codemist and rhelmer December 3, 2024 19:24
Copy link

github-actions bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants