-
Notifications
You must be signed in to change notification settings - Fork 282
MNTOR-5066 - Big data broker FE removal #6314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codemist
wants to merge
34
commits into
main
Choose a base branch
from
mntor-5066
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,301
−37,340
Open
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4ecaf75
remove data broker from dashboard
codemist 7f18d44
big sweep
codemist 709ef55
fix build errors
codemist 320ee16
fix filterexposures component
codemist ada3de5
remove data broker from exposurecarddataclass
codemist 4600fff
fix dashboard top banner
codemist 03e4986
fix resolution container
codemist f539857
fix guided resolution flow
codemist 8a29722
include missed story
codemist 41f1a46
fix build error in high riks data breaches
codemist afe4e1a
remove email address plus const
codemist 2c6f25e
remove emails
codemist 5539019
big sweep
codemist 5692b54
remove isEligibleForPremium guard
codemist 1bd8306
remove dashboard tests
codemist 022a131
fix bad rebase
codemist 8ad23bd
Remove plus settings stories
codemist 8c50d6b
landing page remaining deprecation
codemist 1b67fd9
remove data broker exposure card tests and onerep functions
codemist 3d78536
onerep funcs cleanup
codemist 921899a
remove removalprocess
codemist 5b4deb1
remove cancel flow
codemist 2cd5be2
more code removal
codemist 05848b2
remove location data from build command
codemist d302587
remove broken imports
codemist 54a1858
fix unit tests
codemist 2091b5e
fix breaking build
codemist 956fcdf
add invalid test case
codemist 9d5f86e
fix tests
codemist 8a1d253
remove accounts metric flow and search param logic
codemist 843046d
fix unit tests
codemist f9de655
add useviewtelemetry test
codemist 60a0e4a
fix all tests
codemist be97d80
remove more subscription code
codemist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tracked down why
onDismisswasn’t being passed by default, it was only missing in this dialog component, which seemed inconsistent with our patterns. The dismiss button really should be a non-optional part of the dialog component, so I made it unconditional and added it directly to this component. It looked fine in Storybook, so I also added a test for coverage.