New smart API to list issues

[vrigal]

Based on #2530 (merged)

Closes #2533

All issues that are not returned as known/closed/unresolved can be considered as new.

[vrigal]

I noticed the same combination of (analyzer, level, check, message) may be reported multiple times per file, which would lead to inconsistent returned values. For example, a new issues could be reported as known (if a similar issue is known on this file) or an issue could be returned as both unresolved and closed (in case there are multiple similar issues on a file, and only one has been closed).

I think we should keep this endpoint KISS, and handle such edge cases in the bot.

[La0]

A few comments to address as discussed together.

Then we'll run it on a local prod dump, and can probably ship to testing as it adds new endpoints.

[La0]

You can use the curent diff base repository id to make the query generic & faster (one less join)

Suggested change

	revision__base_repository__slug="mozilla-central",
	revision__base_repository_id=self.diff.revision.base_repository_id,

[vrigal]

revision__base_repository_id=self.diff.revision.base_repository_id do includes all issues from all diffs with the base repository. I suppose it should match revision__head_repository_id instead ?

[La0]

You will also need to serialize the previous_diff_id when applicable (on unresolved & closed issues).

This does not invalidate the fact that a 400 should be raised when it's not present in these cases