Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(settings): Add reg_age_invalid glean metric #17190

Merged
merged 1 commit into from
Jul 1, 2024
Merged

task(settings): Add reg_age_invalid glean metric #17190

merged 1 commit into from
Jul 1, 2024

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Jun 29, 2024

Because

  • We want a metric recorded when a user enters an invalid age

This pull request

  • Creates the reg_age_invalid glean metric
  • Fires the event on the cannot_create_account page

Issue that this pull request solves

Closes: FXA-9421

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

Test instructions

  • Signup for an account
  • Enter email
  • Enter passwords
  • For age enter 10
  • Click Continue
  • Observe the page saying 'You must meet certain age requirements to create a ⁨Mozilla account⁩.'
  • Observe that the reg_invalid_age metric was fired

Because:
- We want a metric recorded when a user enters an invalid age

This Commit:
- Creates the reg_age_invalid glean metric
- Fires the event on the cannot_create_account page
@dschom dschom requested a review from a team as a code owner June 29, 2024 00:03
@chenba chenba merged commit 2fb5540 into main Jul 1, 2024
24 checks passed
@chenba chenba deleted the FXA-9421 branch July 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants