chore(): upgrade to nodemailer 7 #19735
Open
+1,139
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toufali
force-pushed
the
upgrade-to-nodemailer7
branch
2 times, most recently
from
d9059e0 to
66d3250
Compare
toufali
force-pushed
the
upgrade-to-nodemailer7
branch
from
66d3250 to
b25d627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12726
Notes
Nodemailer 7 now negotiates STARTTLS by default. Our legacy mail helper (simplesmtp/rai) that runs in dev/CI is very old and still calls crypto.createCredentials, which no longer exists in Node 22. As soon as Nodemailer tries STARTTLS against that helper, the helper throws and dies, breaking account creation/tests. This only happens in dev/CI, because production/stage use real SMTP endpoints.