fix(payments-next): Prevent unauthorized users from viewing a cart #19755
+69
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * Users can currently view any cart by pasting the link to the cart in the URL This commit: * Adds in a requirement for fetching the cart where if the cart has an associated uid, the correct user must be logged in Closes #PAY-3155
julianpoy
reviewed
Dec 9, 2025
Comment on lines
58
to
+62
| async function getCartOrRedirectAction( | ||
| cartId: string, | ||
| page: SupportedPages, | ||
| searchParams?: Record<string, string | string[]> | ||
| searchParams?: Record<string, string | string[]>, | ||
| uid?: string |
Member
There was a problem hiding this comment.
AFAIK someone can call this action with any UID they want as the last param, nullifying the security of this endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Closes #PAY-3155
Checklist
Put an
xin the boxes that apply