fix(mfa): fix UI issue with MFA modal on mobile #19756
Open
+23
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * The modal jumps on scroll This commit: * prevents the background from scrolling with overscroll-contain and makes scrolling work nicer * adds a story for modal to test out scrolling Closes FXA-12473
MagentaManifold
force-pushed
the
FXA-12473
branch
from
722c3d6 to
5f3006a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12473
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
(I had to make it longer to make it scrollable; this screenshot alone doesn't tell much, since you need to scroll to see the problem)
Other information (Optional)
You might need this to actually out the changes (responsive mode in desktop firefox doesn't have that taskbar, and the taskbar doesn't hide on scroll in storybook): https://mozilla.github.io/ecosystem-platform/reference/mobile-specifics#android-debugging