Skip to content

Conversation

@vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Dec 8, 2025

Because

  • We want to use the FxA uid if the user is signed in

This pull request

  • Uses the FxA uid for local account

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-12697

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

Any other information that is important to this pull request.

@vbudhram vbudhram requested a review from a team as a code owner December 8, 2025 19:03
@vbudhram vbudhram self-assigned this Dec 8, 2025
}

if (!config?.nimbus.enabled || !uniqueUserId) {
const nimbusUserId = legacyLocalStorageAccount?.uid || uniqueUserId;
Copy link
Contributor

@LZoog LZoog Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this isn't necessarily a legacy local storage account, could call it something else here?

Though, potentially an actual issue: this won't update if a user hits Accounts and then signs in or signs up, React won't be reactive to the local storage update to be able to rerun this useEffect based on that dep. This sort of relates to that other follow up issue I filed... I assume we want to address this, and not use the Nimbus uniqueUserId when that happens? LMK if so and if you'll address that elsewhere and I'll r+ this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZoog Yea, this one will be addressed in an upcoming PR. It turned out to be pretty hairy and wanted to keep the PRs separate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will r+ this then 👍

@vbudhram vbudhram requested a review from LZoog December 9, 2025 20:46
@vbudhram vbudhram merged commit 6157c2e into main Dec 10, 2025
19 checks passed
@vbudhram vbudhram deleted the fxa-12697 branch December 10, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants