Skip to content

tests(lib/emails): Add tests for lib/email renderer and sender #19775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nshirley wants to merge 1 commit into
base: main
Choose a base branch
from
+19,737 −24
Open

tests(lib/emails): Add tests for lib/email renderer and sender #19775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions libs/accounts/email-renderer/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
}
},
"test-unit": {
"dependsOn": ["l10n-merge"],
Copy link
Contributor

@dschom dschom Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
Expand Down Expand Up @@ -84,27 +85,17 @@
"command": "npx grunt --gruntfile libs/accounts/email-renderer/gruntfile.js l10n-watch",
"cwd": "."
},
"inputs": [
"{projectRoot}/gruntfile.js",
"{projectRoot}/src/**/en.ftl"
],
"outputs": [
"{projectRoot}/public/en/auth.ftl"
]
"inputs": ["{projectRoot}/gruntfile.js", "{projectRoot}/src/**/en.ftl"],
"outputs": ["{projectRoot}/public/en/auth.ftl"]
},
"l10n-merge": {
"executor": "nx:run-commands",
"options": {
"command": "yarn grunt --gruntfile libs/accounts/email-renderer/gruntfile.js l10n-merge",
"cwd": "."
},
"inputs": [
"{projectRoot}/gruntfile.js",
"{projectRoot}/src/**/en.ftl"
],
"outputs": [
"{projectRoot}/public/en/auth.ftl"
]
"inputs": ["{projectRoot}/gruntfile.js", "{projectRoot}/src/**/en.ftl"],
"outputs": ["{projectRoot}/public/en/auth.ftl"]
},
"l10n-copy": {
"executor": "nx:run-commands",
Expand Down
2 changes: 2 additions & 0 deletions libs/accounts/email-renderer/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ describe('emails', () => {
logoWidth: '100px',
privacyUrl: 'https://mozilla.org/mock-privacy-url',
sync: false,
supportUrl: 'https://mozilla.org/mock-support-url',
unsubscribeUrl: 'https://mozilla.org/mock-unsubscribe-url',
}
);

Expand Down
6 changes: 6 additions & 0 deletions libs/accounts/email-renderer/src/layouts/fxa/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ export type TemplateData = {
/** The current privacy url. */
privacyUrl: string;

/** The current support url. */
supportUrl: string;
Copy link
Contributor

@dschom dschom Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these referenced in the layout template? I'm not seeing them.

Copy link
Contributor Author

@nshirley nshirley Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an error somewhere when a template went to render, I'll remove it to see if I can get it to trip again


/** The current unsubscribe url. */
unsubscribeUrl: string;

/** Whether or not this is a 'sync' specific email. These emails have a slightly different styling */
sync: boolean;
};
Loading