Skip to content

Commit

Permalink
Bug 1928168 - Disable the glean.database.write_time metric by default.
Browse files Browse the repository at this point in the history
  • Loading branch information
travis79 committed Oct 30, 2024
1 parent 5274342 commit 94e97d0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
Safe-mode became the default in Glean v51. ([bug 1780370](https://bugzilla.mozilla.org/show_bug.cgi?id=1780370))
* **BREAKING**: Stop sending buckets with 0 counts in memory_distribution and timing_distribution metric payloads ([bug 1898336](https://bugzilla.mozilla.org/show_bug.cgi?id=1898336))
* Require `glean_parser` v15.2.0 ([bug 1925346](https://bugzilla.mozilla.org/show_bug.cgi?id=1925346))
* Disabled the `glean.database.write_time` metric as the instrumented behavior was triggering metrics pings to be sent containing only that metric ([Bug 1928168](https://bugzilla.mozilla.org/show_bug.cgi?id=1928168))
* Rust
* New Metric Type: `labeled_quantity` ([bug 1925346](https://bugzilla.mozilla.org/show_bug.cgi?id=1925346))

Expand Down
1 change: 1 addition & 0 deletions glean-core/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,7 @@ glean.database:
- [email protected]
- [email protected]
expires: never
disabled: true

glean.validation:
foreground_count:
Expand Down
2 changes: 1 addition & 1 deletion glean-core/src/internal_metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ impl DatabaseMetrics {
category: "glean.database".into(),
send_in_pings: vec!["metrics".into()],
lifetime: Lifetime::Ping,
disabled: false,
disabled: true,
dynamic_label: None,
},
TimeUnit::Microsecond,
Expand Down
1 change: 1 addition & 0 deletions glean-core/tests/ping.rs
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ fn test_scheduled_pings_are_sent() {
}

#[test]
#[ignore] // This metric is disabled by default now, so we can skip this test. See Bug 1928161
fn database_write_timings_get_recorded() {
let (mut glean, _t) = new_glean(None);

Expand Down

0 comments on commit 94e97d0

Please sign in to comment.