In tests register all pings by instantiating them

[badboy]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (00ce5bd) to head (b779e48).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           concistent-ping-names    #3002   +/-   ##
======================================================
  Coverage                  29.54%   29.54%           
======================================================
  Files                          1        1           
  Lines                         44       44           
======================================================
  Hits                          13       13           
  Misses                        31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chutten]

Any reason you went for "build and ref the ping" as the design instead of "create a test-only method for adding ping names to the registry"?

[badboy]

Any reason you went for "build and ref the ping" as the design instead of "create a test-only method for adding ping names to the registry"?

easy copy-pasta I guess.
It does mean I need to touch all these places again when I later add another flag. Let me see if maybe I can refactor that into a method instead.

[badboy]

Any reason you went for "build and ref the ping" as the design instead of "create a test-only method for adding ping names to the registry"?

I updated it and actually moved a bit of duplication into the setup function for the RLB tests.
I'm keeping the instantiation in the examples, because they are ... well, examples. So they are closer to real code.
I also file a bug that we should expose a "register all pings" function in the generated code, so that no one has to ever manually do the _ = &*... dance.