Skip to content

Bug 1933943 - Python: Skip collection_enabled tests on Windows #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Bug 1933943 - Python: Skip collection_enabled tests on Windows #3018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions glean-core/python/tests/test_collection_enabled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@


from pathlib import Path
import pytest
import sys


from glean import Configuration, Glean, load_pings
Expand All @@ -20,6 +22,7 @@
ROOT = Path(__file__).parent


@pytest.mark.skipif(sys.platform == "win32", reason="bug 1933943: Windows failures")
def test_pings_with_follows_false_follow_their_own_setting(tmpdir, helpers):
info_path = Path(str(tmpdir)) / "info.txt"
data_dir = Path(str(tmpdir)) / "glean"
Expand Down Expand Up @@ -73,6 +76,7 @@ def test_pings_with_follows_false_follow_their_own_setting(tmpdir, helpers):
assert 2 == payload["metrics"]["counter"]["local.counter"]


@pytest.mark.skipif(sys.platform == "win32", reason="bug 1933943: Windows failures")
def test_loader_sets_flags(tmpdir, helpers):
info_path = Path(str(tmpdir)) / "info.txt"
data_dir = Path(str(tmpdir)) / "glean"
Expand Down
Loading