Repository navigation
Conversation
chutten
approved these changes
Nov 3, 2026
chutten
left a comment
Contributor
There was a problem hiding this comment.
r+wc it seems good, and I have questions and comments
| @@ -190,15 +193,88 @@ impl FlowRegistry { | |||
| pub(crate) struct FlowState { | |||
| bugs: | ||
| - https://bugzilla.mozilla.org/show_bug.cgi?id=2077138 | ||
| data_reviews: | ||
| - "TODO data review" |
Member
Author
There was a problem hiding this comment.
Noted, I'll take care of this before the stack lands.
- Take the EventMetric itself in flows::lookup and close_instances, so only an event's recording can affect flows, enforced by the type system. - Build the glean.flow_end metadata once in a static rather than per call. - Reuse Glean::maybe_inject_glean_timestamp instead of duplicating it. - Reword the FlowState::open doc to avoid talking about events.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.