Skip to content

Bug 2077138 - Implement the flow lifecycle and the glean.flow_end event - #3739

Open
travis79 wants to merge 2 commits into
Bug2077137from
Bug2077138
Open

travis79 wants to merge 2 commits into
Bug2077137from
Bug2077138

Conversation

@travis79

@travis79 travis79 commented Nov 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@travis79
travis79 added this pull request to stack #3740 November 3, 2026 16:03
@travis79
travis79 requested a review from a team as a code owner November 3, 2026 16:03
@travis79
travis79 requested review from chutten and removed request for a team November 3, 2026 16:03

@chutten chutten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc it seems good, and I have questions and comments

@@ -190,15 +193,88 @@ impl FlowRegistry {
pub(crate) struct FlowState {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP codename "Pine"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone but not forgotten

Comment thread glean-core/src/flows/mod.rs Resolved
Comment thread glean-core/src/flows/mod.rs Resolved
Comment thread glean-core/src/flows/mod.rs Resolved
Comment thread glean-core/src/flows/mod.rs Resolved
Comment thread glean-core/src/flows/mod.rs Resolved
Comment thread glean-core/metrics.yaml
bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=2077138
data_reviews:
- "TODO data review"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahem

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, I'll take care of this before the stack lands.

Comment thread CHANGELOG.md Resolved
- Take the EventMetric itself in flows::lookup and close_instances, so only an
  event's recording can affect flows, enforced by the type system.
- Build the glean.flow_end metadata once in a static rather than per call.
- Reuse Glean::maybe_inject_glean_timestamp instead of duplicating it.
- Reword the FlowState::open doc to avoid talking about events.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants