Templates for Wagtail #6217
Open
Templates for Wagtail #6217
+137
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smithellis
commented
Sep 6, 2024
smithellis
commented
- product_card_preview - the template for a product card
- product_wagtail - a single product template
- products_wagtail - a multiple products template
smithellis
force-pushed
the
01WT-wagtail-page-templates
branch
from
940bce9
to
f9e6181
Compare
- product_card_preview - the template for a product card - product_wagtail - a single product template - products_wagtail - a multiple products template
smithellis
force-pushed
the
01WT-wagtail-page-templates
branch
from
f9e6181
to
f759f3d
Compare
akatsoulas
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
My comment here is that I would prefer to create a template like product_base.html which will be used from both product.html and wagtail_product.html. This way we can avoid a lot of repetition and hopefully have tighter control over the changes without missing anything. I provided both templates to ChatGPT and it came up with a nice base template. We should follow this pattern where applicable. r+wc
|
Let's hold off merging this until the release is out tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.