Update prefer_cms decorator and remove_locale func
#6275
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
reviewed
Oct 2, 2024
kitsune/sumo/decorators.py
Outdated
Comment on lines
184
to
186
| # Set the language code in the request and activate the translation | ||
| request.LANGUAGE_CODE = locale_code | ||
| translation.activate(locale_code) |
There was a problem hiding this comment.
I don't think you need these lines (and the corresponding translation.deactivate() below in the finally clause), since our LocaleMiddleware will take care of that before the request reaches the view function.
smithellis
force-pushed
the
alter-wagtail-decorator
branch
from
4a1fe48
to
6565eec
Compare
* `prefer_cms` will now check if WT page exists in the requested locale instead of just at base path * `remove_locale` now returns the path and the locale_code Update - remove translation
smithellis
force-pushed
the
alter-wagtail-decorator
branch
from
6565eec
to
15da557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefer_cmswill now check if WT page exists in the requested locale instead of just at base pathremove_localenow returns the path and the locale_code