Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds p_values for absolute and relative comparisons #198

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

danielkberry
Copy link
Contributor

@danielkberry danielkberry commented Nov 15, 2023

This PR adds p-values to the output of mozanalysis.bayesian_stats.compare_branches. P-values are calculated using the p-value - confidence interval duality: given a bootstrapped confidence interval (as calculated using the existing methodology), this code calculates the corresponding p-value. A validation notebook is available here

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c69380a) 76.31% compared to head (557fe3c) 76.83%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/mozanalysis/bayesian_stats/__init__.py 88.63% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   76.31%   76.83%   +0.52%     
==========================================
  Files          23       23              
  Lines         992     1036      +44     
==========================================
+ Hits          757      796      +39     
- Misses        235      240       +5     
Flag Coverage Δ
py38 76.83% <88.63%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielkberry danielkberry marked this pull request as ready for review December 1, 2023 23:59
@danielkberry
Copy link
Contributor Author

One open question is around downstream impacts. @mikewilli, what changes need to be made to shared data models to accommodate the new field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants