Embed an sRGB profile if PNG had an sRGB chunk #259
Conversation
| int has_profile = 0; | ||
|
|
||
| if (has_srgb_chunk) { | ||
| /* PNG can declare use of an sRGB profile without embedding an ICC file, but JPEG doesn't have such feature */ |
There was a problem hiding this comment.
👋
JPEG doesn't have such feature
Not entirely true. Unfortunately, both latest Firefox and latest Chrome won’t recognise it properly (Safari does AFAIK), so it’s not safe to use it in output images instead of real ICC profiles. Ingestion tools (like e.g. cjpeg, ImageOptim) should be ideally aware of it in input imagery, though.
There was a problem hiding this comment.
Thanks. That other method requires parsing EXIF, and Adobe's take on it is especially complex (with absolute offsets embedded in TIFF tags), so I'll pass.
There was a problem hiding this comment.
Sure. Adobe’s not a problem, I think, as when files leave it (or originate in it) – a real profile is always embedded (unless user decides otherwise). Problem with colour described in just DCF is with cameras set to AdobeRGB (luckily: never a default). I blame Canon, Nikon et al. And then – Mozilla and Google for not recognising it (can’t claim not knowing about it). Can’t really expect open tools to be correct when both GM and IM are oblivious to it :sadpanda:.
No discernible performance regression Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9447 Credit to OSS Fuzz Closes mozilla#259
No description provided.