fix: Simplify neqo_common::log and enforce clippy format checks
#2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 93.33% 93.33% -0.01%
==========================================
Files 114 114
Lines 36896 36841 -55
Branches 36896 36841 -55
==========================================
- Hits 34438 34386 -52
+ Misses 1675 1671 -4
- Partials 783 784 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to b070663. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Nit: Remove trailing dots to make messages more consistent.
larseggert
changed the title
neqo_common::log with log crate
larseggert
changed the title
neqo_common::log with log crateneqo_common::log and enforce clippy format checks
Signed-off-by: Lars Eggert <[email protected]>
| macro_rules! qerror { | ||
| ([$ctx:expr], $($arg:tt)*) => (::neqo_common::log_invoke!(::log::Level::Error, $ctx, $($arg)*);); | ||
| ($($arg:tt)*) => ( { ::neqo_common::log::init(None); ::neqo_common::do_log!(::log::Level::Error, $($arg)*); } ); | ||
| ($($arg:tt)*) => ( { ::neqo_common::log::init(None); ::log::error!($($arg)*); } ); |
There was a problem hiding this comment.
Could we just use log::trace, etc... directly? I think that most uses of the crate will need to run an init function anyway (for NSS if nothing else), so we can avoid doing the implicit init stuff in a wrapper and rely on people calling the initialization beforehand.
There was a problem hiding this comment.
See #1963. The issue is that if we use log directly, we need to init the module in each test.
There was a problem hiding this comment.
Sounds good. I would observe that perhaps we could keep the wrappers, but avoid the extra initialization step except when we have cfg(test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move variables into format strings where possible and make some other minor improvements.
Offshoot off #1963.