Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(udp): multi-message receive on apple #2302

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(udp): multi-message receive on apple #2302

wants to merge 1 commit into from
+130 −80

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Dec 23, 2024

Do multi-message receive via quinn-rs/quinn#1993 on apple platforms.

Work in progress!

Early benchmarks show ~11% performance improvement in the Download benchmark.

$ critcmp main mmsg                                              
group                                         main                                   mmsg
-----                                         ----                                   ----
1-conn/1-100mb-resp (aka. Download)/client    1.11   790.5±12.51ms   126.5 MB/sec    1.00   711.5±31.65ms   140.5 MB/sec

Fixes #2279.

@github-actions GitHub Actions
Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to bb45c74.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@mxinden mxinden changed the title feat(udp): multi-message receive on apple perf(udp): multi-message receive on apple Dec 23, 2024
martinthomson
martinthomson reviewed Dec 24, 2024
View reviewed changes
neqo-udp/src/lib.rs
target_os = "tvos",
target_os = "visionos"
))]
const BATCH_SIZE: usize = 32;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some commentary about why there is a split and what the benefits of the additional allocation are. 2MB is fine, but knowing why is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson left review comments

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang will be requested when the pull request is marked ready for review KershawChang is a code owner

@larseggert larseggert Awaiting requested review from larseggert larseggert will be requested when the pull request is marked ready for review larseggert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf(udp): enable multi-message IO on apple
2 participants
@mxinden @martinthomson