chore: Enable clippy cfg_not_test
#2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to e5770ce. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
+ Coverage 93.33% 93.34% +0.01%
==========================================
Files 114 114
Lines 36897 36897
Branches 36897 36897
==========================================
+ Hits 34436 34441 +5
Misses 1681 1681
+ Partials 780 775 -5 ☔ View full report in Codecov by Sentry. |
mxinden
reviewed
Jan 10, 2025
|
Seems like we have been calling But that was removed in the same pull request (#1320) that |
mxinden
approved these changes
Jan 10, 2025
Signed-off-by: Lars Eggert <[email protected]>
|
Thanks for checking. So, a leftover. |
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.148 µs 11.179 µs 11.217 µs]
change: [-0.3231% -0.0015% +0.3126%] (p = 0.99 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0141 ms 3.0230 ms 3.0327 ms]
change: [-0.6594% -0.1833% +0.2617%] (p = 0.46 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.537 µs 19.587 µs 19.642 µs]
change: [-0.7494% +0.0066% +0.6358%] (p = 0.98 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1594 ms 5.1708 ms 5.1839 ms]
change: [-0.4460% -0.1022% +0.2532%] (p = 0.57 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5330 µs 5.5557 µs 5.5849 µs]
change: [-0.9013% -0.1575% +0.4802%] (p = 0.68 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.7584 ms 1.7585 ms 1.7587 ms]
change: [-0.7643% -0.3802% -0.0693%] (p = 0.02 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.718 ns 99.078 ns 99.447 ns]
change: [-0.4926% -0.1009% +0.2841%] (p = 0.62 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.44 ns 116.72 ns 117.03 ns]
change: [-1.0687% -0.2224% +0.4080%] (p = 0.62 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.05 ns 117.00 ns 118.76 ns]
change: [-0.7426% +0.1790% +1.4655%] (p = 0.80 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.421 ns 97.583 ns 97.765 ns]
change: [-1.3669% -0.1674% +0.9866%] (p = 0.80 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [110.97 ms 111.10 ms 111.31 ms]
change: [-0.2348% -0.0002% +0.2472%] (p = 1.00 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5117 µs 5.6694 µs 5.8323 µs]
change: [-1.5459% +0.9452% +3.7415%] (p = 0.47 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.532 ms 42.619 ms 42.705 ms]
change: [+1.8467% +2.1502% +2.4450%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.869 ms 42.952 ms 43.039 ms]
change: [+1.9664% +2.2197% +2.4892%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.357 ms 42.423 ms 42.489 ms]
change: [+1.1988% +1.4456% +1.6878%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.853 ms 42.912 ms 42.969 ms]
change: [+1.6890% +1.9234% +2.1481%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [873.00 ms 882.04 ms 891.49 ms]
thrpt: [112.17 MiB/s 113.37 MiB/s 114.55 MiB/s]
change:
time: [-1.9789% -0.5472% +0.9686%] (p = 0.48 > 0.05)
thrpt: [-0.9593% +0.5502% +2.0188%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [300.29 ms 302.69 ms 305.08 ms]
thrpt: [32.778 Kelem/s 33.037 Kelem/s 33.301 Kelem/s]
change:
time: [-0.9239% +0.1043% +1.1507%] (p = 0.85 > 0.05)
thrpt: [-1.1376% -0.1042% +0.9325%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.266 ms 34.459 ms 34.676 ms]
thrpt: [28.839 elem/s 29.020 elem/s 29.183 elem/s]
change:
time: [-0.3453% +0.4480% +1.3090%] (p = 0.29 > 0.05)
thrpt: [-1.2921% -0.4460% +0.3464%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6422 s 1.6621 s 1.6819 s]
thrpt: [59.456 MiB/s 60.166 MiB/s 60.892 MiB/s]
change:
time: [-1.4671% +0.1687% +1.8247%] (p = 0.84 > 0.05)
thrpt: [-1.7920% -0.1684% +1.4890%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#cfg_not_test