chore: Enable the try_err lint#2331
Merged
larseggert merged 5 commits intomozilla:mainfrom Jan 10, 2025
Merged
Conversation
And fix the lint errors
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 6013bde. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2331 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 114 114
Lines 36887 36887
Branches 36887 36887
=======================================
Hits 34428 34428
Misses 1679 1679
Partials 780 780 ☔ View full report in Codecov by Sentry. |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <lars@eggert.org>
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Contributor
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.150 µs 11.180 µs 11.218 µs]
change: [-0.2923% +0.0446% +0.3429%] (p = 0.80 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0154 ms 3.0247 ms 3.0356 ms]
change: [-0.5993% -0.1285% +0.3657%] (p = 0.60 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.543 µs 19.636 µs 19.774 µs]
change: [-0.8346% +0.0895% +1.0876%] (p = 0.88 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1613 ms 5.1740 ms 5.1872 ms]
change: [-0.3893% -0.0408% +0.3194%] (p = 0.82 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5413 µs 5.5784 µs 5.6277 µs]
change: [-0.6063% +0.2147% +1.0696%] (p = 0.63 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7581 ms 1.7596 ms 1.7625 ms]
change: [-0.7105% -0.3201% -0.0017%] (p = 0.10 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.774 ns 99.113 ns 99.477 ns]
change: [-0.3376% +0.1475% +0.5885%] (p = 0.53 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.53 ns 116.83 ns 117.17 ns]
change: [-1.0379% -0.1845% +0.4364%] (p = 0.68 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.33 ns 116.80 ns 117.36 ns]
change: [-0.4606% +0.1939% +0.8235%] (p = 0.57 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.682 ns 97.849 ns 98.038 ns]
change: [-1.1361% +0.0712% +1.2307%] (p = 0.91 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.33 ms 111.38 ms 111.43 ms]
change: [+0.0489% +0.2508% +0.3804%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4221 µs 5.5033 µs 5.5835 µs]
change: [-1.5227% +1.1694% +4.1609%] (p = 0.44 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.266 ms 42.354 ms 42.445 ms]
change: [+1.2113% +1.5162% +1.8104%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.480 ms 42.570 ms 42.668 ms]
change: [+1.0456% +1.3119% +1.6014%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.232 ms 42.299 ms 42.376 ms]
change: [+0.9020% +1.1492% +1.3972%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.220 ms 42.289 ms 42.366 ms]
change: [+0.1944% +0.4434% +0.6975%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [878.96 ms 888.27 ms 897.70 ms]
thrpt: [111.40 MiB/s 112.58 MiB/s 113.77 MiB/s]
change:
time: [-1.3279% +0.1550% +1.7024%] (p = 0.84 > 0.05)
thrpt: [-1.6739% -0.1548% +1.3457%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [301.63 ms 303.84 ms 306.10 ms]
thrpt: [32.669 Kelem/s 32.912 Kelem/s 33.153 Kelem/s]
change:
time: [-0.5076% +0.4857% +1.5470%] (p = 0.36 > 0.05)
thrpt: [-1.5235% -0.4834% +0.5102%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.100 ms 34.246 ms 34.409 ms]
thrpt: [29.062 elem/s 29.201 elem/s 29.325 elem/s]
change:
time: [-0.9173% -0.1736% +0.5529%] (p = 0.65 > 0.05)
thrpt: [-0.5499% +0.1739% +0.9257%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.6680 s 1.6865 s 1.7050 s]
thrpt: [58.651 MiB/s 59.294 MiB/s 59.953 MiB/s]
change:
time: [+0.0066% +1.6410% +3.2042%] (p = 0.05 < 0.05)
thrpt: [-3.1048% -1.6145% -0.0066%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <lars@eggert.org>
auto-merge was automatically disabled
January 10, 2025 06:14
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:16
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:17
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:17
Pull Request is not mergeable
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <lars@eggert.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix the lint errors