chore: Enable the unneeded_field_pattern lint
#2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix the lint errors in the codebase.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 6013bde. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
- Coverage 93.33% 93.33% -0.01%
==========================================
Files 114 114
Lines 36887 36887
Branches 36887 36887
==========================================
- Hits 34428 34427 -1
Misses 1679 1679
- Partials 780 781 +1 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.165 µs 11.204 µs 11.249 µs]
change: [-0.0974% +0.2950% +0.7193%] (p = 0.19 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0158 ms 3.0256 ms 3.0378 ms]
change: [-0.5990% -0.0978% +0.4461%] (p = 0.71 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.564 µs 19.621 µs 19.681 µs]
change: [-0.6215% +0.2975% +1.4536%] (p = 0.61 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1631 ms 5.1833 ms 5.2109 ms]
change: [-0.3587% +0.1379% +0.7370%] (p = 0.64 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5459 µs 5.5811 µs 5.6206 µs]
change: [-0.7820% -0.0263% +0.6245%] (p = 0.95 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.7580 ms 1.7582 ms 1.7583 ms]
change: [-0.7852% -0.4022% -0.0902%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.864 ns 99.211 ns 99.563 ns]
change: [-0.2410% +0.2400% +0.7216%] (p = 0.34 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.60 ns 117.01 ns 117.43 ns]
change: [-1.1389% -0.3097% +0.2990%] (p = 0.47 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.09 ns 116.43 ns 116.87 ns]
change: [-0.6698% +0.0415% +0.8011%] (p = 0.92 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.628 ns 102.51 ns 113.34 ns]
change: [-0.7645% +2.5283% +7.5015%] (p = 0.38 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.19 ms 112.32 ms 112.54 ms]
change: [+0.8493% +1.0974% +1.3426%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4983 µs 5.6871 µs 5.8936 µs]
change: [-1.2437% +1.4309% +4.1285%] (p = 0.30 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.856 ms 41.948 ms 42.053 ms]
change: [+0.2244% +0.5436% +0.8634%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [41.937 ms 42.010 ms 42.084 ms]
change: [-0.2624% -0.0217% +0.2161%] (p = 0.86 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.278 ms 41.339 ms 41.399 ms]
change: [-1.3837% -1.1461% -0.9145%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [41.559 ms 41.627 ms 41.696 ms]
change: [-1.3686% -1.1279% -0.8890%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💔 Performance has regressed. time: [917.49 ms 926.51 ms 935.70 ms]
thrpt: [106.87 MiB/s 107.93 MiB/s 108.99 MiB/s]
change:
time: [+2.9809% +4.4665% +5.9938%] (p = 0.00 < 0.05)
thrpt: [-5.6549% -4.2756% -2.8946%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [301.55 ms 303.74 ms 306.01 ms]
thrpt: [32.678 Kelem/s 32.923 Kelem/s 33.161 Kelem/s]
change:
time: [-0.5699% +0.4515% +1.4661%] (p = 0.39 > 0.05)
thrpt: [-1.4450% -0.4494% +0.5732%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.171 ms 34.364 ms 34.581 ms]
thrpt: [28.918 elem/s 29.100 elem/s 29.265 elem/s]
change:
time: [-0.6432% +0.1716% +1.0144%] (p = 0.69 > 0.05)
thrpt: [-1.0042% -0.1713% +0.6474%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5898 s 1.6042 s 1.6185 s]
thrpt: [61.785 MiB/s 62.335 MiB/s 62.903 MiB/s]
change:
time: [-4.7044% -3.3173% -1.8337%] (p = 0.00 < 0.05)
thrpt: [+1.8679% +3.4311% +4.9367%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
auto-merge was automatically disabled
January 10, 2025 06:14
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:14
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:15
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:16
Pull Request is not mergeable
auto-merge was automatically disabled
January 10, 2025 06:16
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix the lint errors in the codebase.