chore: Enable the unused_trait_names lint
#2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix all the warnings it generates.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to ef9e4dc. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
approved these changes
Jan 9, 2025
|
@larseggert can you resolve the clippy failure? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 114 114
Lines 36895 36908 +13
Branches 36895 36908 +13
=======================================
+ Hits 34438 34451 +13
Misses 1675 1675
Partials 782 782 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <[email protected]>
Benchmark resultsPerformance differences relative to ef9e4dc. decode 4096 bytes, mask ff: No change in performance detected. time: [11.155 µs 11.187 µs 11.226 µs]
change: [-0.4707% +0.0707% +0.7138%] (p = 0.83 > 0.05)
decode 1048576 bytes, mask ff: 💔 Performance has regressed. time: [3.0154 ms 3.0246 ms 3.0355 ms]
change: [+3.9184% +4.4503% +4.9378%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.506 µs 19.547 µs 19.595 µs]
change: [-0.3559% +0.0144% +0.4845%] (p = 0.95 > 0.05)
decode 1048576 bytes, mask 7f: 💔 Performance has regressed. time: [5.1596 ms 5.1708 ms 5.1837 ms]
change: [+1.2501% +1.6508% +2.0126%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5259 µs 5.5398 µs 5.5591 µs]
change: [-0.8887% -0.1889% +0.4780%] (p = 0.60 > 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [1.7875 ms 1.8002 ms 1.8142 ms]
change: [+25.787% +26.820% +27.917%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.619 ns 98.865 ns 99.122 ns]
change: [-0.4936% -0.1041% +0.2772%] (p = 0.61 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.75 ns 117.10 ns 117.48 ns]
change: [-0.2119% +0.1281% +0.4587%] (p = 0.47 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.47 ns 116.99 ns 117.58 ns]
change: [-0.6390% +0.1402% +0.8084%] (p = 0.72 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [97.547 ns 97.688 ns 97.847 ns]
change: [+0.0154% +1.0823% +2.2833%] (p = 0.05 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.82 ms 110.87 ms 110.93 ms]
change: [-0.5388% -0.4616% -0.3840%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4953 µs 5.6419 µs 5.7882 µs]
change: [-14.802% +0.6726% +17.997%] (p = 0.94 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [41.534 ms 41.618 ms 41.705 ms]
change: [-3.5990% -3.3386% -3.0650%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.004 ms 42.075 ms 42.147 ms]
change: [-3.0270% -2.8017% -2.5750%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💚 Performance has improved. time: [41.363 ms 41.424 ms 41.486 ms]
change: [-3.4358% -3.2357% -3.0384%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [41.185 ms 41.240 ms 41.295 ms]
change: [-5.2847% -5.1025% -4.9095%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [892.88 ms 903.51 ms 914.26 ms]
thrpt: [109.38 MiB/s 110.68 MiB/s 112.00 MiB/s]
change:
time: [+0.1534% +1.7308% +3.3612%] (p = 0.04 < 0.05)
thrpt: [-3.2519% -1.7013% -0.1531%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [303.17 ms 305.48 ms 307.85 ms]
thrpt: [32.483 Kelem/s 32.736 Kelem/s 32.984 Kelem/s]
change:
time: [-0.0293% +0.9437% +1.9760%] (p = 0.07 > 0.05)
thrpt: [-1.9377% -0.9349% +0.0294%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold. time: [34.101 ms 34.254 ms 34.424 ms]
thrpt: [29.050 elem/s 29.194 elem/s 29.325 elem/s]
change:
time: [-2.1805% -1.3343% -0.4680%] (p = 0.00 < 0.05)
thrpt: [+0.4702% +1.3523% +2.2291%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5990 s 1.6137 s 1.6286 s]
thrpt: [61.404 MiB/s 61.969 MiB/s 62.538 MiB/s]
change:
time: [-5.9267% -4.7729% -3.5056%] (p = 0.00 < 0.05)
thrpt: [+3.6330% +5.0121% +6.3001%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix all the warnings it generates.