docs(transport/cc): remove obsolete comment #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no single-packet version of `on_packets_acked`. Signed-off-by: Max Inden <[email protected]>
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
mxinden
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2343 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 114 114
Lines 36844 36844
Branches 36844 36844
==========================================
- Hits 35111 35110 -1
- Misses 1727 1728 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 085fa62. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 085fa62. decode 4096 bytes, mask ff: No change in performance detected. time: [11.146 µs 11.176 µs 11.214 µs]
change: [-0.5063% -0.0049% +0.6022%] (p = 0.99 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0170 ms 3.0266 ms 3.0377 ms]
change: [-1.0348% -0.3593% +0.2585%] (p = 0.30 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.523 µs 19.570 µs 19.621 µs]
change: [-0.3021% +0.0952% +0.5660%] (p = 0.68 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1590 ms 5.1703 ms 5.1832 ms]
change: [-1.3754% -0.4629% +0.1543%] (p = 0.29 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5358 µs 5.5626 µs 5.5955 µs]
change: [-0.4853% +0.0554% +0.5800%] (p = 0.85 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7580 ms 1.7595 ms 1.7624 ms]
change: [-0.0190% +0.0702% +0.2369%] (p = 0.57 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.231 ns 99.539 ns 99.855 ns]
change: [-0.1313% +0.2223% +0.6146%] (p = 0.25 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.15 ns 117.53 ns 117.91 ns]
change: [-0.4169% +0.0917% +0.5493%] (p = 0.72 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.71 ns 117.15 ns 117.69 ns]
change: [-0.0913% +0.5584% +1.2507%] (p = 0.13 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.279 ns 97.424 ns 97.584 ns]
change: [-0.6986% +0.2685% +1.2136%] (p = 0.61 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.30 ms 111.36 ms 111.43 ms]
change: [-0.1004% +0.0607% +0.1884%] (p = 0.45 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4893 µs 5.6366 µs 5.7857 µs]
change: [-4.7561% +3.7405% +18.288%] (p = 0.70 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.919 ms 42.009 ms 42.107 ms]
change: [+0.0937% +0.3725% +0.6541%] (p = 0.01 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [42.070 ms 42.149 ms 42.234 ms]
change: [-0.0717% +0.2167% +0.5012%] (p = 0.14 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.579 ms 41.640 ms 41.706 ms]
change: [-1.1144% -0.9018% -0.7014%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [41.733 ms 41.810 ms 41.898 ms]
change: [+0.5014% +0.7804% +1.0638%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [904.70 ms 915.80 ms 926.94 ms]
thrpt: [107.88 MiB/s 109.19 MiB/s 110.53 MiB/s]
change:
time: [-2.6083% -1.0715% +0.6611%] (p = 0.21 > 0.05)
thrpt: [-0.6567% +1.0831% +2.6782%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [315.01 ms 317.11 ms 319.26 ms]
thrpt: [31.322 Kelem/s 31.535 Kelem/s 31.746 Kelem/s]
change:
time: [-1.4842% -0.5227% +0.4132%] (p = 0.29 > 0.05)
thrpt: [-0.4115% +0.5255% +1.5066%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.299 ms 34.513 ms 34.750 ms]
thrpt: [28.777 elem/s 28.975 elem/s 29.155 elem/s]
change:
time: [-0.2366% +0.5813% +1.4568%] (p = 0.18 > 0.05)
thrpt: [-1.4359% -0.5779% +0.2372%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.6442 s 1.6617 s 1.6795 s]
thrpt: [59.541 MiB/s 60.180 MiB/s 60.821 MiB/s]
change:
time: [-4.0319% -2.7659% -1.4325%] (p = 0.00 < 0.05)
thrpt: [+1.4533% +2.8446% +4.2013%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Jan 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
There is no single-packet version of `on_packets_acked`. Signed-off-by: Max Inden <[email protected]> Co-authored-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no single-packet version of
on_packets_acked.