docs(transport/cubic): add references to RFC 8312 #2344
+82
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
- Coverage 95.29% 93.01% -2.28%
==========================================
Files 114 114
Lines 36844 36850 +6
Branches 36844 36850 +6
==========================================
- Hits 35110 34276 -834
- Misses 1728 1796 +68
- Partials 6 778 +772 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 085fa62. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 085fa62. decode 4096 bytes, mask ff: No change in performance detected. time: [11.143 µs 11.171 µs 11.206 µs]
change: [-0.6481% -0.2745% +0.0744%] (p = 0.14 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0178 ms 3.0274 ms 3.0385 ms]
change: [-1.0086% -0.3313% +0.2865%] (p = 0.33 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.518 µs 19.566 µs 19.620 µs]
change: [-0.3276% -0.0010% +0.3190%] (p = 0.99 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1575 ms 5.1686 ms 5.1815 ms]
change: [-1.4041% -0.4952% +0.1221%] (p = 0.25 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5262 µs 5.5470 µs 5.5736 µs]
change: [-0.7139% -0.2108% +0.2712%] (p = 0.40 > 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [1.7805 ms 1.7930 ms 1.8056 ms]
change: [+1.3207% +1.9762% +2.6831%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.969 ns 99.308 ns 99.662 ns]
change: [-0.1455% +0.9080% +2.4907%] (p = 0.21 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.57 ns 116.83 ns 117.12 ns]
change: [-0.8009% -0.3031% +0.1242%] (p = 0.22 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.58 ns 117.11 ns 117.72 ns]
change: [-0.2020% +0.4362% +1.1727%] (p = 0.23 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.453 ns 101.37 ns 110.23 ns]
change: [-0.4462% +3.0665% +8.9215%] (p = 0.33 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.53 ms 111.59 ms 111.64 ms]
change: [+0.1032% +0.2617% +0.3815%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4979 µs 5.6467 µs 5.8041 µs]
change: [-3.1568% -0.4709% +2.2046%] (p = 0.74 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.457 ms 42.551 ms 42.649 ms]
change: [+1.3523% +1.6671% +1.9587%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.885 ms 42.965 ms 43.048 ms]
change: [+1.8584% +2.1571% +2.4598%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.666 ms 42.746 ms 42.838 ms]
change: [+1.4870% +1.7300% +1.9990%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.739 ms 42.825 ms 42.920 ms]
change: [+2.9551% +3.2279% +3.5297%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [920.73 ms 932.25 ms 944.04 ms]
thrpt: [105.93 MiB/s 107.27 MiB/s 108.61 MiB/s]
change:
time: [-0.9853% +0.7055% +2.4190%] (p = 0.42 > 0.05)
thrpt: [-2.3619% -0.7005% +0.9951%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [320.80 ms 322.98 ms 325.17 ms]
thrpt: [30.754 Kelem/s 30.962 Kelem/s 31.172 Kelem/s]
change:
time: [+0.3356% +1.3179% +2.3204%] (p = 0.01 < 0.05)
thrpt: [-2.2678% -1.3008% -0.3345%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.198 ms 34.415 ms 34.653 ms]
thrpt: [28.858 elem/s 29.057 elem/s 29.242 elem/s]
change:
time: [-0.5569% +0.2964% +1.2146%] (p = 0.50 > 0.05)
thrpt: [-1.2000% -0.2956% +0.5600%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.7182 s 1.7361 s 1.7539 s]
thrpt: [57.015 MiB/s 57.601 MiB/s 58.199 MiB/s]
change:
time: [+0.2539% +1.5888% +2.9871%] (p = 0.03 < 0.05)
thrpt: [-2.9005% -1.5639% -0.2533%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Jan 13, 2025
|
@mxinden LGTM modulo the clippy issue |
larseggert
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves documentation in general and adds references to the relevant sections of RFC 8312.
Once we update to RFC 9438 (#1912), we should reference RFC 9438 instead.