Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump lukemathwalker/cargo-chef from ee4eb4c to 8f50c89 in /qns #2346

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps lukemathwalker/cargo-chef from ee4eb4c to 8f50c89.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps lukemathwalker/cargo-chef from `ee4eb4c` to `8f50c89`.

---
updated-dependencies:
- dependency-name: lukemathwalker/cargo-chef
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 13, 2025
@dependabot dependabot bot requested a review from KershawChang as a code owner January 13, 2025 08:41
@dependabot dependabot bot added the docker Pull requests that update Docker code label Jan 13, 2025
Copy link

Failed Interop Tests

None ❓

All results

Succeeded Interop Tests

None ❓

Unsupported Interop Tests

None ❓

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (085fa62) to head (68a3d68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2346   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         114      114           
  Lines       36844    36844           
  Branches    36844    36844           
=======================================
+ Hits        35110    35111    +1     
+ Misses       1728     1727    -1     
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

Performance differences relative to 085fa62.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.166 µs 11.206 µs 11.253 µs]
       change: [-0.4563% -0.0404% +0.3805%] (p = 0.85 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
2 (2.00%) low severe
5 (5.00%) low mild
9 (9.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0175 ms 3.0272 ms 3.0383 ms]
       change: [-1.0458% -0.3396% +0.2907%] (p = 0.32 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
10 (10.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.532 µs 19.585 µs 19.642 µs]
       change: [-0.4119% -0.1013% +0.2043%] (p = 0.52 > 0.05)

Found 24 outliers among 100 measurements (24.00%)
2 (2.00%) low severe
8 (8.00%) low mild
1 (1.00%) high mild
13 (13.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.1637 ms 5.1765 ms 5.1899 ms]
       change: [-1.2671% -0.3440% +0.3049%] (p = 0.47 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
1 (1.00%) high mild
16 (16.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [5.5285 µs 5.5466 µs 5.5731 µs]
       change: [-0.7515% -0.3118% +0.0725%] (p = 0.15 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.7580 ms 1.7581 ms 1.7583 ms]
       change: [-0.0191% -0.0058% +0.0068%] (p = 0.39 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.150 ns 99.494 ns 99.842 ns]
       change: [-0.2690% +0.1748% +0.6383%] (p = 0.46 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [116.98 ns 117.35 ns 117.73 ns]
       change: [-0.4231% +0.1904% +0.7954%] (p = 0.55 > 0.05)

Found 21 outliers among 100 measurements (21.00%)
2 (2.00%) low severe
3 (3.00%) low mild
3 (3.00%) high mild
13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.75 ns 117.20 ns 117.74 ns]
       change: [-0.0642% +0.4639% +1.0464%] (p = 0.12 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
3 (3.00%) low severe
4 (4.00%) low mild
1 (1.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.283 ns 97.418 ns 97.579 ns]
       change: [-0.9789% -0.1203% +0.7786%] (p = 0.80 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
4 (4.00%) high mild
4 (4.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.25 ms 111.29 ms 111.33 ms]
       change: [-0.1580% -0.0055% +0.1105%] (p = 0.95 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) low mild
4 (4.00%) high mild

SentPackets::take_ranges: No change in performance detected.
       time:   [5.4791 µs 5.6293 µs 5.7813 µs]
       change: [-5.0793% +3.5955% +18.253%] (p = 0.72 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [41.694 ms 41.785 ms 41.887 ms]
       change: [-0.4543% -0.1639% +0.1700%] (p = 0.29 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [42.035 ms 42.109 ms 42.182 ms]
       change: [-0.1545% +0.1228% +0.4014%] (p = 0.39 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [41.819 ms 41.883 ms 41.953 ms]
       change: [-0.5307% -0.3228% -0.0873%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [42.163 ms 42.234 ms 42.309 ms]
       change: [+1.5449% +1.8034% +2.0657%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved.
       time:   [885.03 ms 894.61 ms 904.49 ms]
       thrpt:  [110.56 MiB/s 111.78 MiB/s 112.99 MiB/s]
change:
       time:   [-4.8704% -3.3601% -1.7317%] (p = 0.00 < 0.05)
       thrpt:  [+1.7622% +3.4769% +5.1197%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [317.60 ms 319.85 ms 322.12 ms]
       thrpt:  [31.045 Kelem/s 31.264 Kelem/s 31.486 Kelem/s]
change:
       time:   [-0.6784% +0.3380% +1.3237%] (p = 0.50 > 0.05)
       thrpt:  [-1.3064% -0.3369% +0.6831%]

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [34.297 ms 34.455 ms 34.631 ms]
       thrpt:  [28.876  elem/s 29.023  elem/s 29.157  elem/s]
change:
       time:   [-0.2978% +0.4136% +1.1267%] (p = 0.27 > 0.05)
       thrpt:  [-1.1142% -0.4119% +0.2987%]

Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
3 (3.00%) high mild
3 (3.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.6716 s 1.6899 s 1.7084 s]
       thrpt:  [58.534 MiB/s 59.174 MiB/s 59.824 MiB/s]
change:
       time:   [-2.5285% -1.1119% +0.3040%] (p = 0.12 > 0.05)
       thrpt:  [-0.3030% +1.1244% +2.5941%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 509.8 ± 9.9 499.8 528.9
neqo gquiche reno on 1504 764.7 ± 21.6 730.9 808.1
neqo gquiche reno 1504 744.1 ± 18.4 707.7 772.8
neqo gquiche cubic on 1504 749.7 ± 13.7 723.5 770.8
neqo gquiche cubic 1504 740.4 ± 18.1 708.4 762.8
msquic msquic 1504 106.6 ± 14.4 93.3 155.6
neqo msquic reno on 1504 216.0 ± 15.7 202.9 262.5
neqo msquic reno 1504 216.1 ± 15.6 199.0 254.4
neqo msquic cubic on 1504 226.2 ± 34.5 201.2 310.8
neqo msquic cubic 1504 219.3 ± 20.5 199.4 273.6
gquiche neqo reno on 1504 672.3 ± 92.5 543.1 822.2
gquiche neqo reno 1504 659.4 ± 77.9 544.5 773.4
gquiche neqo cubic on 1504 693.6 ± 91.4 560.2 832.5
gquiche neqo cubic 1504 670.5 ± 94.0 533.2 803.9
msquic neqo reno on 1504 472.8 ± 11.1 457.1 489.4
msquic neqo reno 1504 499.9 ± 70.5 449.9 678.4
msquic neqo cubic on 1504 471.5 ± 10.1 459.4 485.5
msquic neqo cubic 1504 483.3 ± 30.9 460.9 567.0
neqo neqo reno on 1504 449.0 ± 9.3 436.6 462.6
neqo neqo reno 1504 445.8 ± 13.5 431.6 471.2
neqo neqo cubic on 1504 460.7 ± 10.3 446.6 474.7
neqo neqo cubic 1504 457.8 ± 32.1 432.7 543.6

⬇️ Download logs

@larseggert
Copy link
Collaborator

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 13, 2025

Superseded by #2354.

@dependabot dependabot bot closed this Jan 13, 2025
@dependabot dependabot bot deleted the dependabot/docker/qns/lukemathwalker/cargo-chef-8f50c894d2cdf6896838b3731b152a0f96f4e0c6dd80673eb5a84b03dd66eae5 branch January 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant