Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump actions/upload-artifact from 4.5.0 to 4.6.0 #2351

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps actions/upload-artifact from 4.5.0 to 4.6.0.

Release notes

Sourced from actions/upload-artifact's releases.

v4.6.0

What's Changed

Full Changelog: actions/upload-artifact@v4...v4.6.0

Commits
  • 65c4c4a Merge pull request #662 from actions/yacaovsnc/add_variable_for_concurrency_a...
  • 0207619 move files back to satisfy licensed ci
  • 1ecca81 licensed cache updates
  • 9742269 Expose env vars to controll concurrency and timeout
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 13, 2025
@dependabot dependabot bot requested a review from larseggert as a code owner January 13, 2025 08:53
@dependabot dependabot bot added the github_actions Pull requests that update GitHub Actions code label Jan 13, 2025
@dependabot dependabot bot requested a review from mxinden as a code owner January 13, 2025 08:53
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (9abde4e) to head (6badae4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2351   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         114      114           
  Lines       36844    36844           
  Branches    36844    36844           
=======================================
  Hits        35111    35111           
  Misses       1727     1727           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 13, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 085fa62.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

Benchmark results

Performance differences relative to 085fa62.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.151 µs 11.184 µs 11.224 µs]
       change: [-0.4874% -0.0153% +0.4531%] (p = 0.95 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low severe
3 (3.00%) low mild
1 (1.00%) high mild
8 (8.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0154 ms 3.0241 ms 3.0343 ms]
       change: [-1.1244% -0.4422% +0.1410%] (p = 0.18 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.516 µs 19.565 µs 19.619 µs]
       change: [-0.3916% -0.0561% +0.2948%] (p = 0.76 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
1 (1.00%) low severe
4 (4.00%) low mild
13 (13.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.1606 ms 5.1722 ms 5.1853 ms]
       change: [-1.3502% -0.4264% +0.2035%] (p = 0.35 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
14 (14.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [5.5508 µs 5.5883 µs 5.6294 µs]
       change: [-0.3385% +0.2222% +0.7611%] (p = 0.45 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
2 (2.00%) high mild
10 (10.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.7584 ms 1.7613 ms 1.7655 ms]
       change: [+0.0086% +0.1730% +0.4799%] (p = 0.08 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.341 ns 99.723 ns 100.10 ns]
       change: [-0.0720% +0.3566% +0.8086%] (p = 0.11 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
9 (9.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [116.97 ns 117.36 ns 117.81 ns]
       change: [-0.4073% +0.2755% +1.0620%] (p = 0.51 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
2 (2.00%) low severe
2 (2.00%) low mild
1 (1.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.53 ns 116.97 ns 117.50 ns]
       change: [-0.2912% +0.2523% +0.8692%] (p = 0.40 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
4 (4.00%) low severe
1 (1.00%) low mild
2 (2.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.129 ns 97.269 ns 97.425 ns]
       change: [-0.9655% -0.1022% +0.7684%] (p = 0.83 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.16 ms 111.30 ms 111.52 ms]
       change: [-0.2006% +0.0029% +0.2730%] (p = 0.98 > 0.05)

Found 24 outliers among 100 measurements (24.00%)
2 (2.00%) low severe
9 (9.00%) low mild
10 (10.00%) high mild
3 (3.00%) high severe

SentPackets::take_ranges: No change in performance detected.
       time:   [5.5236 µs 5.7064 µs 5.9038 µs]
       change: [-2.4252% +0.4625% +3.3050%] (p = 0.75 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [40.657 ms 40.733 ms 40.809 ms]
       change: [-2.9376% -2.6774% -2.4309%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [41.064 ms 41.134 ms 41.205 ms]
       change: [-2.4654% -2.1962% -1.9339%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

transfer/pacing-false/same-seed: 💚 Performance has improved.
       time:   [40.234 ms 40.300 ms 40.368 ms]
       change: [-4.3027% -4.0905% -3.8657%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [40.568 ms 40.634 ms 40.708 ms]
       change: [-2.2999% -2.0530% -1.7921%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved.
       time:   [874.48 ms 884.58 ms 894.97 ms]
       thrpt:  [111.74 MiB/s 113.05 MiB/s 114.35 MiB/s]
change:
       time:   [-5.9556% -4.4435% -2.8741%] (p = 0.00 < 0.05)
       thrpt:  [+2.9591% +4.6502% +6.3328%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [313.84 ms 316.00 ms 318.18 ms]
       thrpt:  [31.429 Kelem/s 31.645 Kelem/s 31.863 Kelem/s]
change:
       time:   [-1.8356% -0.8695% +0.1248%] (p = 0.08 > 0.05)
       thrpt:  [-0.1246% +0.8771% +1.8699%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [34.048 ms 34.228 ms 34.425 ms]
       thrpt:  [29.049  elem/s 29.216  elem/s 29.370  elem/s]
change:
       time:   [-1.0263% -0.2490% +0.5252%] (p = 0.53 > 0.05)
       thrpt:  [-0.5224% +0.2497% +1.0369%]

Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.7055 s 1.7239 s 1.7425 s]
       thrpt:  [57.389 MiB/s 58.009 MiB/s 58.634 MiB/s]
change:
       time:   [-0.4392% +0.8744% +2.2792%] (p = 0.22 > 0.05)
       thrpt:  [-2.2284% -0.8669% +0.4411%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 518.5 ± 10.1 506.3 530.7
neqo gquiche reno on 1504 751.3 ± 11.0 738.3 769.1
neqo gquiche reno 1504 764.7 ± 52.4 725.6 908.3
neqo gquiche cubic on 1504 763.2 ± 7.7 750.9 772.7
neqo gquiche cubic 1504 753.0 ± 14.8 731.3 788.2
msquic msquic 1504 138.4 ± 70.2 99.5 326.8
neqo msquic reno on 1504 264.8 ± 65.8 211.1 442.2
neqo msquic reno 1504 218.7 ± 16.5 201.5 265.2
neqo msquic cubic on 1504 247.2 ± 73.1 205.6 440.0
neqo msquic cubic 1504 249.4 ± 48.5 214.1 393.4
gquiche neqo reno on 1504 666.3 ± 92.3 546.5 788.7
gquiche neqo reno 1504 674.4 ± 84.4 543.5 793.1
gquiche neqo cubic on 1504 674.4 ± 82.6 538.3 790.0
gquiche neqo cubic 1504 703.1 ± 105.4 562.1 876.3
msquic neqo reno on 1504 467.3 ± 10.7 456.5 485.7
msquic neqo reno 1504 507.4 ± 37.0 476.5 596.8
msquic neqo cubic on 1504 485.2 ± 52.3 421.8 604.1
msquic neqo cubic 1504 498.0 ± 34.7 469.8 571.6
neqo neqo reno on 1504 437.3 ± 10.7 422.8 455.6
neqo neqo reno 1504 479.1 ± 49.4 441.6 587.1
neqo neqo cubic on 1504 448.1 ± 8.8 438.6 464.1
neqo neqo cubic 1504 485.4 ± 53.6 452.6 608.9

⬇️ Download logs

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4.6.0 branch 2 times, most recently from a65e4e7 to 1566b68 Compare January 13, 2025 14:21
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@6f51ac0...65c4c4a)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4.6.0 branch from 1566b68 to 6103de6 Compare January 13, 2025 14:25
@larseggert larseggert enabled auto-merge January 13, 2025 14:37
@larseggert larseggert disabled auto-merge January 13, 2025 14:38
@larseggert larseggert enabled auto-merge January 13, 2025 14:39
@larseggert larseggert disabled auto-merge January 13, 2025 15:01
@larseggert larseggert merged commit 8f5233a into main Jan 13, 2025
64 of 67 checks passed
@larseggert larseggert deleted the dependabot/github_actions/actions/upload-artifact-4.6.0 branch January 13, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant