Skip to content

Revert "Update to Debian 12, PostgreSQL 15, Node.js 18 in Docker (#3115)" #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mathjazz
Copy link
Collaborator

This reverts commit fb25c53.

@flodolo Could you please give this an r+, so that I can merge it and see if collectstatic doesn't break in the GH workflow of #3117?

@mathjazz mathjazz requested a review from flodolo February 23, 2024 11:54
@flodolo
Copy link
Collaborator

flodolo commented Feb 23, 2024

I don't understand…

  1. It is still failing even after you backed out the changes in that PR.
  2. At least one of them (using latest action versions in workflow) is as safe as a change could get.

@flodolo
Copy link
Collaborator

flodolo commented Feb 23, 2024

This has exactly the same changes you had and it worked on the first try? 🤔
#3120

@flodolo
Copy link
Collaborator

flodolo commented Feb 23, 2024

Since even this PR failed, I'm trying to re-running it to understand if it was a temporary problem in GitHub infra

@flodolo
Copy link
Collaborator

flodolo commented Feb 23, 2024

Since even this PR failed, I'm trying to re-running it to understand if it was a temporary problem in GitHub infra

It worked this time, so I'd suggest to restore #3117 to the single commit and see if checks pass.

Copy link
Collaborator

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my tests, it doesn't look like the problem was necessarily related to these changes.

@mathjazz
Copy link
Collaborator Author

Interesting - seems like it was a temp issue with GH Actions.

@mathjazz mathjazz closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants