Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full URLs in notifications #3468

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Dec 3, 2024

Some notification types (suggestions available for review, suggestions have been reviewed and new contributor has joined the team) use relative URLs. That means they won't work in emails. This patch fixes that.

It also:

  • Moves notification content from multiline strings to HTML templates.
  • Moves management commands for sending notifications to the messaging module.
  • Moves notification template files to the messaging module.

@mathjazz mathjazz requested a review from eemeli December 3, 2024 14:33
@mathjazz mathjazz merged commit 6273ecb into mozilla:main Dec 3, 2024
2 checks passed
@mathjazz mathjazz deleted the full-url-in-notifications branch December 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants