-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Font Awesome 6.7.2 (from 5.0.13), minimize size #3504
base: main
Are you sure you want to change the base?
Conversation
This would add about 180kB to Pontoon's first load size. What is the benefit of this change? |
Use a maintained, up-to-date version of an external dependency? |
Look like v5 is still supported (latest version being 5.15.14) |
With that said, I wonder if we should look into optimizing this 🤔 |
I've looked into optimizing the font, but it's a ton of work just to identify which icons we're using in the code 😞 |
Tried minimizing the font via Python+fonttools, seems to work locally and the gain is about 110k One downside is that the font binary file changes at every run 🤔 |
If the approach sounds reasonable, we should put the script in the |
Not sure if there's more to this.
I took the
all.css
file and copied over asfontawesome-all.css
, corrected the font rules to only use.woff2
.For example, I changed
to