Fix sync - updating source string from VCS not working #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add more details on the issue/behavior you're trying to fix, so that it can be reproduced? |
eemeli
requested changes
Jan 3, 2025
There was a problem hiding this comment.
This needs to include a test case that fails with the current code, but passes with the changes. It's not at all clear what entity change is not getting picked up by the current code.
There are also two parts to this change: How differences are identified, and whether the previous or next entity is used in Entity.objects.bulk_update(). Are both changes required?
| "source", | ||
| "group_comment", | ||
| "resource_comment", | ||
| "context", |
Comment on lines
+336
to
+338
| def entity_update( | ||
| current: Entity, update_from: Entity, fields: list[str] | ||
| ) -> Optional[Entity]: |
There was a problem hiding this comment.
This is replacing the only use of entities_same() with a new function; we should not leave orphaned code lying around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After source string changed in the git repo, a project sync won't update the source string in the Pontoon project. Tested with a json formatted source file.