Add refresh fonts #1030
Add refresh fonts #1030
Conversation
|
CI will be broken until the new tokens are available from protocol-tokens package |
| descent-override: 25.6%; | ||
| line-gap-override: 0%; | ||
| size-adjust: 120.76%; | ||
| } |
There was a problem hiding this comment.
Unadjusted
Adjusted
| descent-override: 30%; | ||
| line-gap-override: 0%; | ||
| size-adjust: 115.96%; | ||
| } |
There was a problem hiding this comment.
Unadjusted
Adjusted
maureenlholland
force-pushed
the
add-refresh-fonts
branch
from
1c22c80 to
1196cf9
Compare
| @@ -23,6 +23,9 @@ h6 { | |||
|
|
|||
| @supports (--css: variables) { | |||
| font-family: var(--title-font-family); | |||
| font-variant-ligatures: var(--title-font-ligatures); | |||
| font-weight: var(--title-font-weight); | |||
There was a problem hiding this comment.
This is problematic, it overrides the 700 font weight and makes the inherited 500 weight take effect. Needs a default fallback value or a Firefox-themed variable value
(pr)
(prod)
There was a problem hiding this comment.
default fallback value works as expected
- [breaking] Zilla Slab font is removed for Mozilla rebrand fonts - [breaking] the font-mozilla mixin is removed in favor of more explicit font-mozilla-text and font-mozilla-headline
This approach ensures we have a common default (bold) across all themes that don't choose to set a custom font-weight
maureenlholland
force-pushed
the
add-refresh-fonts
branch
from
5289589 to
e993c57
Compare
|
This is ready for local code review and can be merged when updated with new tokens from Protocol Tokens PR: mozilla/protocol-tokens#114 DO NOT MERGE until tokens package is released and updated |
maureenlholland
added
Do Not Merge ⚠️
| @@ -23,6 +24,9 @@ h6 { | |||
|
|
|||
| @supports (--css: variables) { | |||
| font-family: var(--title-font-family); | |||
| font-variant-ligatures: var(--title-font-ligatures); | |||
There was a problem hiding this comment.
mozilla/bedrock#15790 (comment)
just noticed this comment on another PR, maybe best to use none as default here as well
|
|
||
| * [Download from Github](https://github.com/mozilla/zilla-slab/releases/latest) |
There was a problem hiding this comment.
There's a repo https://github.com/mozilla/mozilla-type-family — however it still only houses pre-release versions.
Q: Is there any chance a prod-level asset will be provided at some point, perhaps adding more i18n support et al.?
Co-authored-by: Jan Brasna <[email protected]>
Description
This approach is the breaking change. It removes Zilla Slab token, font files, and mixin.
Fallback font adjustments used this tool: https://highperformancewebfonts.com/tools/fafofal/
Mozilla heading styles need
Mozilla body styles need
CHANGELOG.md.Related PR
Needs new Protocol Tokens package: mozilla/protocol-tokens#114 [WIP]
Issue
#1029
Testing
Run locally and check font updates in http://localhost:3000/docs/fundamentals/typography
Build package locally and update local package in Bedrock: mozilla/bedrock#16083
(After local install on Bedrock, I was manually moving the
mozilla-protocol/core/package/protocolfolder up to be directly insidecorefolder, there's probably a better way to do that)Check Mozilla branded pages have correct font styling
Check Firefox branded pages have correct font styling