Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer to ‹details› element ‹summary› #1042

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

janbrasna
Copy link
Contributor

Description

Details element gets styled very close to Details component with many of the enhancements, just the hover affordance is missing for this plan HTML5 use case. This sets the cursor to pointer, as the full component does.

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

Resolves #948

Testing

https://patch-2--mzp-dev.netlify.app/components/detail/details

  1. I have not fenced this behind any @supports not (-ms-ime-align: auto) of sorts for things like IE that don't provide the functionality as that adds extra cruft (and false positives) for not much benefit, when MzpDetails actually provides a polyfill for such browsers.
  2. I have opted for a plain extra declaration instead of the @summary mixin (which gets included within half a dozen of things) not to apply such styling to places that render it own ways.

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ ☝️

@stephaniehobson stephaniehobson merged commit d650b24 into mozilla:main Mar 19, 2025
1 check passed
@janbrasna janbrasna deleted the add/details-summary-pointer branch March 19, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply hover cursor from Details component to Details element too
2 participants