Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb styling #938

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Jun 20, 2024

Description

Fixes positioning bug in wider layouts and makes the overall alignment more consistent with other navigation items.

  • The breakpoints mirror what .mzp-l-content sets horizontally, using exactly the same tokens.
  • The updated spacing and padding is to match existing nav elements, to look aligned next to each other, whether stacked with submenu on desktop or aligned to its dropdown version on mobile etc.
  • Since the breadcrumb link has underline removed, this also adds it back on hover for a little affordance, as the change from #0060df to #0250bb is not really noticeable. (Consumers often do this, or the other way around with underline in og state.)

TODO:

(Q: now $mq-lg looks a little out of place; also consider $spacing vs $layout vs $h-grid? TBC check where the existing lg metric math actually comes from…)

🚧 Revisit the component default state (i.e. SM vs XS size?) as shown in the component preview difference:
https://preview--mzp-dev.netlify.app/components/detail/breadcrumb
vs.
https://main--mzp-dev.netlify.app/components/detail/breadcrumb

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

Resolves #933

Testing

see bedrock issues and pages to test mozilla/bedrock#14081 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs are wider than other site content
1 participant