Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature test support #1789

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Improve feature test support #1789

merged 5 commits into from
Jan 8, 2025

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Jan 3, 2025

  • enhance Utils a bit to support feature testing
  • migrate a feature test case from core-js to rhino (found while updating to the latest rhino source)

Copy link
Contributor

@andreabergia andreabergia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Removing all those various context factory makes it quite a bit more readable.

I would suggest a slightly different API name though, i.e. rather than

        factory = new Utils.FeatureContextFactory(Context.FEATURE_DYNAMIC_SCOPE);

have something like:

        factory = Utils.contextFactoryWithFeatures(Context.FEATURE_DYNAMIC_SCOPE);

@rbri
Copy link
Collaborator Author

rbri commented Jan 7, 2025

@andreabergia good point, will do that update

@gbrail
Copy link
Collaborator

gbrail commented Jan 8, 2025

Looks good to me -- thanks!

@gbrail gbrail merged commit 3b3b5e2 into mozilla:master Jan 8, 2025
3 checks passed
@rbri rbri deleted the feature_tests branch January 8, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants