Enable TLS support for Redis#976
Merged
sylvestre merged 2 commits intomozilla:masterfrom Nov 11, 2021
Merged
Conversation
Collaborator
Contributor
Author
|
@Xanewok Could you take another look? This time, I haven't upgraded the redis-rs version at all, just fiddled with the features. Turns out several default features are not used and were bloating I've also added a small improvement (masking the password in the Redis URL if there is one). |
sylvestre
reviewed
Oct 31, 2021
| /// Create a new `RedisCache`. | ||
| pub fn new(url: &str) -> Result<RedisCache> { | ||
| let mut parsed = Url::parse(url)?; | ||
| if parsed.password().is_some() { |
Collaborator
There was a problem hiding this comment.
Could you please add a comment to explain that it is for the TLS support? thanks
Contributor
Author
There was a problem hiding this comment.
This change is unrelated to TLS. Still, I updated the diff to match paritytech/cachepot#98.
Contributor
Author
|
Hi @sylvestre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables TLS for Redis backends. Tested against an AWS ElastiCache Redis with TLS. I'm a Rust newbie so I don't know if the dependency changes (in
Cargo.lock) are OK.