Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1891121 - Add experiment brief links to experiment and rollout tables #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarahhjchung
Copy link
Collaborator

Bug 1891121

Changes made:

  • RecipeInfo now includes an experimentBriefLink property with the url to experiment link Google docs
  • A tooltip button of the FileText icon from lucide-icons is now displayed next to the experiment/rollout name if an experiment brief link exists

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for fxms-skylight failed. Why did it fail? →

Name Link
🔨 Latest commit 19d3652
🔍 Latest deploy log https://app.netlify.com/sites/fxms-skylight/deploys/6763442e70111500084dc54d

@sarahhjchung
Copy link
Collaborator Author

DocumentationLinks were exposed in the experimenter v7 api and I am able to get the data from it. However, I'm getting build failures due to documentationLinks not being defined in the node_modules/@mozilla/nimbus-shared/types/experiments.ts file. Is this file something that needs to be updated by us or something we need to request the nimbus team for?

@dmose
Copy link
Member

dmose commented Dec 19, 2024

We need to request that the experimenter team do it (or put in a PR ourselves and ask for their review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants