This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
Fix yaml linting issue in ci.yml file and getting tests to run #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
force-pushed
the
ci-file-linting
branch
from
a984e8b to
250a7a3
Compare
willkg
changed the title
willkg
force-pushed
the
ci-file-linting
branch
2 times, most recently
from
df122e3 to
2e05d9d
Compare
Sphinx 7.3.0 included a cosmetic change to param lists where if the param has no description, it omits the " --". That's fine except sphinx-js tests are very fragile in respects to the Sphinx output. This includes Sphinx < 7.3.0 and Sphinx >= 7.3.0 expected output for relevant tests.
u'' is a Python 2 thing we don't need anymore.
This removes the "npm list --all" call I added earlier to reduce test output.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to figure out if CI worked, so I did a cosmetic fix to the
ci.ymlfile.That unearthed some problem with linkify-it or markdown-it. Updating jsdoc from 4.0.0 to 4.0.4 got those tests passing, but only for Python 3.8.
We want to drop support for Python 3.8 anyhow, so I dropped that now so that all the environments are failing the same way. But that didn't pan out as I had hoped.
Turns out Sphinx v7.3.0 includes a cosmetic change that's not in the changelog that drops the
" --"from param lists if there's no param description. I added explicit handling for that.That gets CI working again.