Bindgen refactors #2358
Open
Bindgen refactors #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `Enum::variant_discr_iter` and use that to implement `variant_discr`. This provides a simple and efficient way for other code to get a Vec of discriminants. Renamed `uniffi_checksum_derive` -> `uniffi_internal_macros`. This way we can use the same crate for future internal macros. This is prep work for the bindings IR patch I'm hoping to land.
bendk
force-pushed
the
push-vxokmoyvpuvx
branch
from
f33e4c7 to
4c0de8c
Compare
gruberb
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Enum::variant_discr_iterand use that to implementvariant_discr. This provides a simple and efficient way for other code to get a Vec of discriminants.Renamed
uniffi_checksum_derive->uniffi_internal_macros. This way we can use the same crate for future internal macros.This is prep work for the bindings IR patch I'm hoping to land.