Ability to change server virtual host name#176
Open
ZAZPRO wants to merge 2 commits intompgirro:mainfrom
Open
Conversation
aleksanderbl29
added a commit
to aleksanderbl29/docker-pihole-unbound
that referenced
this pull request
Jun 27, 2023
aleksanderbl29
added a commit
to aleksanderbl29/docker-pihole-unbound
that referenced
this pull request
Jun 27, 2023
Owner
|
Thank you for your contribution! Unfortunately this was never merged be the original maintainer. Is this change still valid and relevant for Pihole v6? |
Author
Thank you for your appreciation. Judging by the official migration guide here VIRTUAL_HOST environment variable was removed without a replacement as no longer used. (Full list of variables is quickly accessible on the bottom of the page) So I would assume that this change is not longer valid or relevant for new major v6 version of Pihole. You can safely close this issue in my opinion if you wish so. Kind regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my personal setup I had troubles changing default url address using which I could access pihole. As I am new to pihole it took me a while to find a reason of this. Even redirecting requests wasn't working as expected as pihole redirects to /admin/ page only from virtual host name. This pull request might help people with the same issue.